pc: fix: inline value when def indentation equals 2 #22990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Robert Marek <[email protected]>
KacperFKorban
requested changes
Apr 12, 2025
| noPrefixH ++ t.map(refIndent ++ _.stripPrefix(defIndent)).mkString("\n","\n", "") | ||
| else | ||
| ((" " ++ h) :: t).map(refIndent ++ _.stripPrefix(defIndent)).mkString("\n", "\n", "") | ||
| val header = if h.startsWith("{") then h else "\n" ++ refIndent ++ " " ++ h |
There was a problem hiding this comment.
Nice find!
Although, I think that the h.startsWith("{") is wrong too 🙈
The else branch should most likely only be performed if the start line number of the rhs is different than the end line number of the definition.
tgodzik
pushed a commit
to scala/scala3-lts
that referenced
this pull request
May 5, 2025
Co-authored-by: Robert Marek <[email protected]>
tgodzik
added a commit
to scala/scala3-lts
that referenced
this pull request
May 5, 2025
Co-authored-by: Robert Marek <[email protected]> [Cherry-picked 48e8328][modified]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.